new op awaiter construct api#41
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors how io_uring operation awaiters are constructed by introducing new build_*_op_awaiter helpers and relocating the existing make_* factory helpers under condy::detail, updating library code and tests accordingly.
Changes:
- Add
build_op_awaiter,build_multishot_op_awaiter, andbuild_zero_copy_op_awaitertemplates to centralize awaiter construction. - Move
make_op_awaiter/make_multishot_*/make_zero_copy_*helpers intocondy::detailand update call sites across the library. - Update tests to use
condy::detail::make_*factories.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| include/condy/awaiter_operations.hpp | Introduces new build_* awaiter constructors and moves make_* helpers into condy::detail. |
| include/condy/async_operations.hpp | Updates async wrappers to call detail::make_* factories. |
| tests/test_task.cpp | Updates test awaiter creation to condy::detail::make_op_awaiter. |
| tests/test_runtime.cpp | Updates runtime tests to use condy::detail::make_op_awaiter. |
| tests/test_op_awaiter.cpp | Updates op_awaiter tests to use condy::detail::make_* factories. |
| tests/test_fd_table.cpp | Updates fixed-fd tests to use condy::detail::make_op_awaiter. |
| tests/test_buffer_table.cpp | Updates registered-buffer tests to use condy::detail::make_op_awaiter. |
| tests/test_awaiter_operations.cpp | Updates awaiter operations tests to use condy::detail::make_op_awaiter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.